Merged
Conversation
…sitive runtime deps Signed-off-by: Patrick Flynn <patrick@chainguard.dev>
Contributor
Author
|
I tested this with a new gradle image and seems 👍 |
jdolitsky
approved these changes
Apr 19, 2023
jdolitsky
reviewed
Apr 19, 2023
Member
jdolitsky
left a comment
jdolitsky
left a comment
There was a problem hiding this comment.
looks like new version of gradle too
2023/04/19 20:39:10 error during command execution: 1 error occurred:
* package gradle-8: update found newer version 8.1.0 compared with package.version 8.0.2 in melange config
```
Contributor
Author
|
@jdolitsky yeah this fixes the build so that update PR will pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix gradle build due to openjdk-11 in build deps and coming from transitive runtime deps
Related:
review thread on #1203
I suspect this might be an apko regression as I don't understand how this was working before.
One thing that I'm wondering about is why gradle pulls in JRE as runtime deps while maven doesn't. I don't know what the right thing but it's definitely inconsistent right now.